gmtime_s and localtime_s are Microsoft extensions that appeared in Visual Studio 2005 (aka Version 8.0). gmtime and localtime are already thread safe in MicroSoft C library, so following patch makes it possible to build with Mingw and eventually with Visual Studio 7.1 or lower.
Created attachment 30356 [details] cater for older MS compilers and for GCC that does not have localtime_s and gmtime_s
Created attachment 30372 [details] Clean proper standard-compliant patch with a proper clean ChangeLog entry
Comment on attachment 30372 [details] Clean proper standard-compliant patch with a proper clean ChangeLog entry The ChangeLog entry has tabs in it, and lacks an email address. As best I can make out, the patch doesn’t do what the ChangeLog describes either. It uses localtime_s on older versions of MSVC, and uses localtime on newer versions. That doesn’t fit with the ChangeLog saying that localtime_s doesn’t exist on older versions.
Created attachment 30373 [details] This patch even has the proper e-mail address and spaces instead of tabs
Created attachment 30374 [details] And now the patch also does what it pretends
Comment on attachment 30374 [details] And now the patch also does what it pretends Looks good. r=me
Landed as r44130.