RESOLVED WORKSFORME 25805
In debug build, mingw win32 build has problems with powf 
https://bugs.webkit.org/show_bug.cgi?id=25805
Summary In debug build, mingw win32 build has problems with powf
Fridrich Strba
Reported 2009-05-14 14:10:48 PDT
In mingw32 w32api and runtime, the powf function is _CRT_INLINE, but in debug build -O0, compiler fails to inline it and then there is problem of linking. The following patch makes the use of the proper overloade C++ pow (which is actually using compiler builtins with mingw). It makes the code even a bit more C++ like and does not break anything.
Attachments
use a proper C++ overloaded pow instead of C-style powf (1.38 KB, patch)
2009-05-14 14:11 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
Clean proper standard-compliant patch with a proper clean ChangeLog entry (2.17 KB, patch)
2009-05-15 00:32 PDT, Fridrich Strba 		fridrich.strba: review-
DetailsFormatted DiffDiff
This patch even has the proper e-mail address and spaces instead of tabs (2.18 KB, patch)
2009-05-15 01:42 PDT, Fridrich Strba 		eric: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fridrich Strba
Comment 1 2009-05-14 14:11:36 PDT
Created attachment 30355 [details] use a proper C++ overloaded pow instead of C-style powf
Darin Adler
Comment 2 2009-05-14 14:14:33 PDT
Comment on attachment 30355 [details] use a proper C++ overloaded pow instead of C-style powf Needs ChangeLog. Needs testing on all the major platforms that WebKit supports. Generally seems strange to do this here when the rest of the project takes the other approach.
Fridrich Strba
Comment 3 2009-05-15 00:32:37 PDT
Created attachment 30368 [details] Clean proper standard-compliant patch with a proper clean ChangeLog entry
Fridrich Strba
Comment 4 2009-05-15 00:50:56 PDT
I also submitted also a bug report against the mingw toolchain https://sourceforge.net/tracker/?func=detail&aid=2792082&group_id=2435&atid=102435
Fridrich Strba
Comment 5 2009-05-15 01:42:15 PDT
Created attachment 30375 [details] This patch even has the proper e-mail address and spaces instead of tabs
Maciej Stachowiak
Comment 6 2009-05-21 22:59:58 PDT
Comment on attachment 30375 [details] This patch even has the proper e-mail address and spaces instead of tabs Looks good.
Xan Lopez
Comment 7 2009-05-22 00:29:58 PDT
(In reply to comment #6) > (From update of attachment 30375 [details] [review]) > Looks good. > Committed as r44035.
Xan Lopez
Comment 8 2009-05-22 01:39:00 PDT
After various attempts to make this compile and work in Mac, Windows (MSVC) and Linux we ended up reverting the patch in r44039. Reopening the bug.
Eric Seidel (no email)
Comment 9 2009-05-22 08:26:11 PDT
Comment on attachment 30375 [details] This patch even has the proper e-mail address and spaces instead of tabs Marking r- since this was rolled out. (Thus removing it from the commit queue)
Fridrich Strba
Comment 10 2010-03-04 05:50:58 PST
I did not see this problem anymore since I changed the runtime implementation I build against
Note You need to log in before you can comment on or make changes to this bug.