Bug 25804 - symbols in win32 libraries also use leading underscore
Summary: symbols in win32 libraries also use leading underscore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-14 13:33 PDT by Fridrich Strba
Modified: 2009-05-25 08:48 PDT (History)
4 users (show)

See Also:

Attachments
This patch adds underscore to functions written in asembly even for win32 (974 bytes, patch)
2009-05-14 13:35 PDT, Fridrich Strba 		no flags Details | Formatted Diff | Diff
Hopefully a fully compliant patch (1.59 KB, patch)
2009-05-15 01:51 PDT, Fridrich Strba 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridrich Strba 2009-05-14 13:33:42 PDT 
Following patch solves some linking issues when building with mingw (gcc for win32). The functions written in assembly need to have leading underscore
Comment 1 Fridrich Strba 2009-05-14 13:35:04 PDT 
Created attachment 30353 [details]
This patch adds underscore to functions written in asembly even for win32
Comment 2 Holger Freyther 2009-05-14 20:29:57 PDT 
One general remark. Please read http://webkit.org/coding/contributing.html.
Comment 3 Fridrich Strba 2009-05-15 01:51:22 PDT 
Created attachment 30378 [details]
Hopefully a fully compliant patch
Comment 4 Maciej Stachowiak 2009-05-21 23:01:04 PDT 
Is this still correct when building with Visual Studio? Should it be ifdef'd to limit it to mingw on Windows perhaps?
Comment 5 Fridrich Strba 2009-05-21 23:57:10 PDT 
The code is already in a branch that is compiled only #if !COMPILER(MSVC)
Comment 6 Fridrich Strba 2009-05-22 00:10:08 PDT 
Sorry, a precision not in the branch where !COMPILER(MSVC), but in the branch where COMPILER(GCC) which is equivalent for our purposes here :)
Comment 7 Maciej Stachowiak 2009-05-22 00:58:24 PDT 
Comment on attachment 30378 [details]
Hopefully a fully compliant patch

r=me then
Comment 8 Xan Lopez 2009-05-25 08:48:39 PDT 
Landed as r44131.