Bug 257931 - Add parsing support for word-boundary-detection
Summary: Add parsing support for word-boundary-detection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-09 20:57 PDT by Myles C. Maxfield
Modified: 2023-06-13 00:33 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2023-06-09 20:57:06 PDT 
Add parsing support for word-boundary-detection
Comment 1 Radar WebKit Bug Importer 2023-06-09 20:57:23 PDT 
<rdar://problem/110562385>
Comment 2 Myles C. Maxfield 2023-06-09 21:07:01 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14843
Comment 3 EWS 2023-06-10 19:17:39 PDT 
Committed 265057@main (9e639f149ac0): <https://commits.webkit.org/265057@main>

Reviewed commits have been landed. Closing PR #14843 and removing active labels.
Comment 4 Diego Pino 2023-06-11 22:39:33 PDT 
WebKitGTK Debian Stable bot build is failing with the following error after this change:

https://build.webkit.org/#/builders/46/builds/30880

FAILED:
In file included from WTF/Headers/wtf/StdLibExtras.h:33,
                 from WTF/Headers/wtf/FastMalloc.h:26,
                 from ../../Source/WebCore/config.h:47,
                 from WebCore/DerivedSources/JSDOMPoint.cpp:21,
                 from WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-34.cpp:1:
/usr/include/c++/10/variant: In instantiation of ‘constexpr const size_t std::variant_size_v<WebCore::WordBoundaryDetection>’:
/usr/include/c++/10/variant:1039:10:   required from ‘struct std::__detail::__variant::__gen_vtable<std::__detail::__variant::__deduce_visit_result<void>, WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >&&, WebCore::WordBoundaryDetection&>’
/usr/include/c++/10/variant:1699:45:   required from ‘constexpr decltype(auto) std::__do_visit(_Visitor&&, _Variants&& ...) [with _Result_type = std::__detail::__variant::__deduce_visit_result<void>; _Visitor = WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >; _Variants = {WebCore::WordBoundaryDetection&}]’
/usr/include/c++/10/variant:1718:35:   required from ‘constexpr decltype(auto) std::visit(_Visitor&&, _Variants&& ...) [with _Visitor = WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >; _Variants = {WebCore::WordBoundaryDetection&}]’
WTF/Headers/wtf/StdLibExtras.h:445:54:   required by substitution of ‘template<class V, class ... F> decltype (std::visit(WTF::makeVisitor((forward<F>)(WTF::switchOn::f)...), forward<V>(v))) WTF::switchOn(V&&, F&& ...) [with V = WebCore::WordBoundaryDetection&; F = {WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)>}]’
../../Source/WebCore/rendering/style/WordBoundaryDetection.h:59:6:   required from here
/usr/include/c++/10/variant:97:70: error: incomplete type ‘std::variant_size<WebCore::WordBoundaryDetection>’ used in nested name specifier
   97 |     inline constexpr size_t variant_size_v = variant_size<_Variant>::value;
      |                                                                      ^~~~~
/usr/include/c++/10/variant: In instantiation of ‘constexpr decltype(auto) std::__do_visit(_Visitor&&, _Variants&& ...) [with _Result_type = std::__detail::__variant::__deduce_visit_result<void>; _Visitor = WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >; _Variants = {WebCore::WordBoundaryDetection&}]’:
/usr/include/c++/10/variant:1718:35:   required from ‘constexpr decltype(auto) std::visit(_Visitor&&, _Variants&& ...) [with _Visitor = WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >; _Variants = {WebCore::WordBoundaryDetection&}]’
Comment 5 Diego Pino 2023-06-12 00:00:45 PDT 
Re-opening for pull request https://github.com/webkit/webkit/pull/14855
Comment 6 EWS 2023-06-13 00:33:15 PDT 
Committed 265109@main (6ff8c5f88a55): <https://commits.webkit.org/265109@main>

Reviewed commits have been landed. Closing PR #14855 and removing active labels.