Bug 257832 - [ iOS, macOS ] imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html is a constant ImageOnly failure
Summary: [ iOS, macOS ] imported/w3c/web-platform-tests/html/rendering/the-details-ele...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bri Harris
URL:
Keywords: InRadar
Depends on:
Blocks: 252223
  Show dependency treegraph
 
Reported: 2023-06-07 14:20 PDT by Bri Harris
Modified: 2023-11-09 15:18 PST (History)
6 users (show)

See Also:


Attachments
Image Diffs (6.30 KB, text/html)
2023-06-07 14:20 PDT, Bri Harris
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2023-06-07 14:20:42 PDT
<rdar://problem/110421013>
Comment 2 Bri Harris 2023-06-07 14:29:43 PDT
I was able to replicate this failure on Ventura ToT as follows:

run-webkit-tests --root imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html
Comment 3 Bri Harris 2023-06-07 14:35:32 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14762
Comment 4 EWS 2023-06-07 14:37:32 PDT
Test gardening commit 264957@main (2dd4f2cd5de8): <https://commits.webkit.org/264957@main>

Reviewed commits have been landed. Closing PR #14762 and removing active labels.
Comment 5 Alexey Proskuryakov 2023-06-12 22:22:51 PDT
This test was marked as failing since it was imported in 2020, but it was supposed to have been fixed in https://commits.webkit.org/264901@main, so the expectation was removed.

EWS didn't tell us about this because bug 258005.
Comment 6 Ahmad Saleem 2023-06-13 01:41:14 PDT
(In reply to Alexey Proskuryakov from comment #5)
> This test was marked as failing since it was imported in 2020, but it was
> supposed to have been fixed in https://commits.webkit.org/264901@main, so
> the expectation was removed.
> 
> EWS didn't tell us about this because bug 258005.

My commit was to introduce 'underline' (text decoration propogation), which was not done before and it seems to load fine when locally I did patch and since WPT had test coverage, I just enable the same tests but it seems 'underline' we get but it might cause 'bullet' or 'triangle' to get squashed.

Should we revert our patch or consider it is just one test with 'ImageOnly failure'? and undo expectation?