Bug 25782 - Allow custom memory allocation control in JavaScriptCore
Summary: Allow custom memory allocation control in JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-14 02:01 PDT by Zoltan Horvath
Modified: 2009-06-04 11:35 PDT (History)
0 users

See Also:


Attachments
proposed patch for HashTable (1.38 KB, patch)
2009-05-14 02:02 PDT, Zoltan Horvath
mjs: review+
Details | Formatted Diff | Diff
proposed patch for HashTable struct (3.98 KB, patch)
2009-06-02 06:16 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
proposed patch for HashTable struct (deleted)
2009-06-02 10:23 PDT, Zoltan Horvath
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-05-14 02:01:21 PDT
FastAllocBase class landed in the trunk (bug #20422) at r42344. 
Now we have to continue the work with inherite some classes from it. 
TODOs:
- We have to inherit every classes from FastAllocBase which has been instantiated by 'new'. 
- We have to put FastAllocBase into inheritance tree as far up as possible.

First I file a patch for one class called HashTable. After it'll be in the trunk I'll file a list which classes instantiated by 'new'.
Comment 1 Zoltan Horvath 2009-05-14 02:02:18 PDT
Created attachment 30319 [details]
proposed patch for HashTable
Comment 2 Maciej Stachowiak 2009-05-22 01:18:47 PDT
Comment on attachment 30319 [details]
proposed patch for HashTable

r=me
Comment 3 Brent Fulgham 2009-05-26 15:28:04 PDT
Landed in @r44161.
Comment 4 Zoltan Horvath 2009-06-02 06:15:17 PDT
I've analysed the source and noticed that I inherited the wrong HashTable class. Sorry, I've filed a new patch which contains the correction of the mistake and the allocation support for the 'real' HashTable. Details in the patch.
Comment 5 Zoltan Horvath 2009-06-02 06:16:12 PDT
Created attachment 30868 [details]
proposed patch for HashTable struct
Comment 6 Zoltan Horvath 2009-06-02 09:20:40 PDT
Simplier method is to change 'new' call to fastNew, and 'delete' to fastDelete. (In this case I need to modify only where HashTable instantiated by 'new' and destructed with delete. JSGlobalData.cpp:106-112) 
If you wish I could attach a patch with this solution.
Comment 7 Zoltan Horvath 2009-06-02 10:23:56 PDT
Created attachment 30871 [details]
proposed patch for HashTable struct

Based on Darin's https://bugs.webkit.org/show_bug.cgi?id=20422#c36 comment, I filed the fastNew/fastDelete solution.
Comment 8 Darin Adler 2009-06-02 12:25:02 PDT
Comment on attachment 30871 [details]
proposed patch for HashTable struct

r=me
Comment 9 Brent Fulgham 2009-06-03 15:50:50 PDT
Assign for landing.
Comment 10 Brent Fulgham 2009-06-04 10:30:57 PDT
Landed in @r44417.