Bug 257788 - Investigate using Markable instead of std::optional for ScrollbarColor
Summary: Investigate using Markable instead of std::optional for ScrollbarColor
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 16
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 257571
Blocks: 231590
  Show dependency tree / graph
 
Reported: 2023-06-07 03:21 PDT by Luke Warlow
Modified: 2023-06-16 03:26 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Warlow 2023-06-07 03:21:21 PDT 
We should check with the dump-class-layout, but the optional might make it align at 12 bytes (4 for each StyleColor).
Using a custom Markable<ScrollbarColor> when any of the underlying color is invalid could save 4 bytes
Comment 1 Radar WebKit Bug Importer 2023-06-14 03:22:17 PDT 
<rdar://problem/110765163>
Comment 2 Luke Warlow 2023-06-16 03:26:22 PDT 
Implemented as part of initial bug