WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257717
Resolutions in calc should always be serialized to dppx
https://bugs.webkit.org/show_bug.cgi?id=257717
Summary
Resolutions in calc should always be serialized to dppx
Tim Nguyen (:ntim)
Reported
2023-06-05 09:15:17 PDT
The canonical unit for resolution is dppx, we should always convert resolutions to use that unit. See failures at:
https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-06-05 09:15:27 PDT
<
rdar://problem/110265669
>
Cheng You Bai (:cybai)
Comment 2
2023-06-21 23:59:02 PDT
I also noticed the failures in
https://wpt.fyi/results/css/mediaqueries/match-media-parsing.html?label=experimental&label=master&aligned
related to this issue. May I work on this one?
Ryan Reno
Comment 3
2023-06-22 11:49:10 PDT
(In reply to Cheng You Bai (:cybai) from
comment #2
)
> I also noticed the failures in >
https://wpt.fyi/results/css/mediaqueries/match-media-parsing
. > html?label=experimental&label=master&aligned related to this issue. May I > work on this one?
Please do, thanks!
Cheng You Bai (:cybai)
Comment 4
2023-06-22 23:28:54 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/15229
EWS
Comment 5
2023-06-23 11:39:10 PDT
Committed
265469@main
(a4c5bcd2ebf9): <
https://commits.webkit.org/265469@main
> Reviewed commits have been landed. Closing PR #15229 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug