Bug 257685 - [IFC] Remove redundant LineBuilder::computedIntrinsicWidth
Summary: [IFC] Remove redundant LineBuilder::computedIntrinsicWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-03 21:11 PDT by zalan
Modified: 2023-06-05 13:33 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.62 KB, patch)
2023-06-03 21:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (7.62 KB, patch)
2023-06-05 11:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-06-03 21:11:28 PDT 
ssia
Comment 1 zalan 2023-06-03 21:35:57 PDT 
Created attachment 466586 [details]
Patch
Comment 2 Antti Koivisto 2023-06-05 01:54:31 PDT 
Comment on attachment 466586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466586&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:431
> -        auto intrinsicContent = lineBuilder.computedIntrinsicWidth({ layoutRange, { 0.f, 0.f, horizontalConstraints.logicalWidth, 0.f } }, previousLine);
> +        auto lineLayoutResult = lineBuilder.layoutInlineContent({ layoutRange, { 0.f, 0.f, horizontalConstraints.logicalWidth, 0.f } }, previousLine);

nice!
Comment 3 zalan 2023-06-05 11:26:47 PDT 
Created attachment 466595 [details]
[fast-cq]Patch
Comment 4 EWS 2023-06-05 13:32:28 PDT 
Committed 264872@main (e25dc4918f88): <https://commits.webkit.org/264872@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466595 [details].
Comment 5 Radar WebKit Bug Importer 2023-06-05 13:33:21 PDT 
<rdar://problem/110273921>