RESOLVED FIXED 257685
[IFC] Remove redundant LineBuilder::computedIntrinsicWidth 
https://bugs.webkit.org/show_bug.cgi?id=257685
Summary [IFC] Remove redundant LineBuilder::computedIntrinsicWidth
zalan
Reported 2023-06-03 21:11:28 PDT
ssia
Attachments
Patch (7.62 KB, patch)
2023-06-03 21:35 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (7.62 KB, patch)
2023-06-05 11:26 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2023-06-03 21:35:57 PDT
Created attachment 466586 [details] Patch
Antti Koivisto
Comment 2 2023-06-05 01:54:31 PDT
Comment on attachment 466586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466586&action=review > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:431 > - auto intrinsicContent = lineBuilder.computedIntrinsicWidth({ layoutRange, { 0.f, 0.f, horizontalConstraints.logicalWidth, 0.f } }, previousLine); > + auto lineLayoutResult = lineBuilder.layoutInlineContent({ layoutRange, { 0.f, 0.f, horizontalConstraints.logicalWidth, 0.f } }, previousLine); nice!
zalan
Comment 3 2023-06-05 11:26:47 PDT
Created attachment 466595 [details] [fast-cq]Patch
EWS
Comment 4 2023-06-05 13:32:28 PDT
Committed 264872@main (e25dc4918f88): <https://commits.webkit.org/264872@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466595 [details].
Radar WebKit Bug Importer
Comment 5 2023-06-05 13:33:21 PDT
<rdar://problem/110273921>
Note You need to log in before you can comment on or make changes to this bug.