WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257650
Move WebCore::RunLoopObserver from WebCore/platform/cf to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=257650
Summary
Move WebCore::RunLoopObserver from WebCore/platform/cf to WebCore/platform
Wenson Hsieh
Reported
2023-06-02 09:12:16 PDT
...so that we can use it in (otherwise) platform-agnostic code. For now, this will only have a concrete implementation when `USE(CF)` is defined, but we could make it work with other ports (e.g. `GLIB_EVENT_LOOP` / `WINDOWS_EVENT_LOOP`) as well, in a followup.
Attachments
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2023-06-02 09:27:53 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14630
Radar WebKit Bug Importer
Comment 2
2023-06-09 09:13:17 PDT
<
rdar://problem/110531974
>
EWS
Comment 3
2023-06-12 14:19:08 PDT
Committed
265089@main
(a1236fc76789): <
https://commits.webkit.org/265089@main
> Reviewed commits have been landed. Closing PR #14630 and removing active labels.
Diego Pino
Comment 4
2023-06-12 23:08:19 PDT
WebKitGTK Release post-commit build bot is failing after this patch landed:
https://build.webkit.org/#/builders/41/builds/19615/steps/10/logs/stdio
from /app/webkit/Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:21, from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-51.cpp:1: /app/webkit/Source/WebCore/platform/VideoEncoderActiveConfiguration.h:35:12: error: field ‘codec’ has incomplete type ‘WTF::String’ 35 | String codec; | ^~~~~ It's a non-unified sources build error, `#include <WTFString.h>` is missing.
Diego Pino
Comment 5
2023-06-12 23:08:59 PDT
Re-opening for pull request
https://github.com/webkit/webkit/pull/14907
EWS
Comment 6
2023-06-12 23:17:34 PDT
Committed
265105@main
(90873fe270bf): <
https://commits.webkit.org/265105@main
> Reviewed commits have been landed. Closing PR #14907 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug