RESOLVED FIXED257641
Remove unnecessary check in `TreeResolver::resolvePseudoElement()` 
https://bugs.webkit.org/show_bug.cgi?id=257641
Summary Remove unnecessary check in `TreeResolver::resolvePseudoElement()`
Vitaly Dyackhov
Reported 2023-06-02 01:11:15 PDT
``` // FIXME: This test shouldn't be needed. bool alwaysNeedsPseudoElement = resolvedStyle->style->hasAnimationsOrTransitions() || element.hasKeyframeEffects(pseudoId) || pseudoId == PseudoId::FirstLine || pseudoId == PseudoId::FirstLetter || pseudoId == PseudoId::Scrollbar; if (!alwaysNeedsPseudoElement && !pseudoElementRendererIsNeeded(resolvedStyle->style.get())) return { }; ```
Attachments
Add attachment proposed patch, testcase, etc.
Vitaly Dyackhov
Comment 1 2023-06-02 01:14:39 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14620
Radar WebKit Bug Importer
Comment 2 2023-06-09 01:12:15 PDT
<rdar://problem/110515283>
EWS
Comment 3 2023-06-20 07:12:06 PDT
Committed 265318@main (ad52c1163560): <https://commits.webkit.org/265318@main> Reviewed commits have been landed. Closing PR #14620 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.