WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257575
RenderTable::BottomSection() should return the last rendered table section
https://bugs.webkit.org/show_bug.cgi?id=257575
Summary
RenderTable::BottomSection() should return the last rendered table section
Ahmad Saleem
Reported
2023-05-31 17:21:04 PDT
Hi Team, Just came across following potential bug fix but without Layout Test case, so I would leave it for someone else to fix but just wanted to raise. Blink Commit:
https://chromium.googlesource.com/chromium/src.git/+/9c14979722d3761c5449f3ef9f68bd2fee4f82a0
WebKit Source:
https://github.com/WebKit/WebKit/blob/734687da6292d68e3d571f781719887cc8e74bbd/Source/WebCore/rendering/RenderTable.cpp#L1435
Patch: if (m_foot) return m_foot.get(); if (m_head && !firstBody()) return m_head.get(); for (RenderObject* child = lastChild(); child; child = child->previousSibling()) { if (child == m_head) continue; ____________- Just wanted to raise, so we can fix it. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2023-06-04 21:08:38 PDT
I think this needs a test case and it should not be too hard to come up with one.
Radar WebKit Bug Importer
Comment 2
2023-06-07 17:22:16 PDT
<
rdar://problem/110430887
>
Karl Dubost
Comment 3
2023-06-15 05:51:51 PDT
Alan, do you have an example of CPP test file elsewhere in the code?
Karl Dubost
Comment 4
2025-01-27 04:30:04 PST
Pull request:
https://github.com/WebKit/WebKit/pull/39589
Tim Nguyen (:ntim)
Comment 5
2025-01-27 20:59:30 PST
WPT PR:
https://github.com/web-platform-tests/wpt/pull/50328
EWS
Comment 6
2025-01-28 05:14:54 PST
Committed
289434@main
(1d539b1ae929): <
https://commits.webkit.org/289434@main
> Reviewed commits have been landed. Closing PR #39589 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug