WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257500
Use StringView more in ScriptElement and EmailInputType
https://bugs.webkit.org/show_bug.cgi?id=257500
Summary
Use StringView more in ScriptElement and EmailInputType
Anne van Kesteren
Reported
2023-05-30 10:36:44 PDT
As suggested here
https://github.com/WebKit/WebKit/pull/14467#pullrequestreview-1451367941
. The event and for attribute values are used for comparisons only, so StringView would be more efficient. Looks like there is no need to convert from AtomString to String for these either. RegularExpression::match() already takes a StringView so updating isValidEmailAddress() should be straightforward.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-05-30 23:23:54 PDT
<
rdar://problem/110047074
>
Anne van Kesteren
Comment 2
2023-05-31 00:24:32 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14527
EWS
Comment 3
2023-05-31 09:43:41 PDT
Committed
264736@main
(f8eaba1e9189): <
https://commits.webkit.org/264736@main
> Reviewed commits have been landed. Closing PR #14527 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug