WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257474
[JSC] Implement isNaN / Number.isNaN in C++
https://bugs.webkit.org/show_bug.cgi?id=257474
Summary
[JSC] Implement isNaN / Number.isNaN in C++
Yusuke Suzuki
Reported
2023-05-30 02:52:55 PDT
...
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-05-30 02:53:08 PDT
<
rdar://problem/109996676
>
Yusuke Suzuki
Comment 2
2023-05-30 02:54:08 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14473
EWS
Comment 3
2023-05-30 13:54:27 PDT
Committed
264697@main
(5d3b2384ab2b): <
https://commits.webkit.org/264697@main
> Reviewed commits have been landed. Closing PR #14473 and removing active labels.
WebKit Commit Bot
Comment 4
2023-05-31 08:38:09 PDT
Re-opened since this is blocked by
bug 257541
Alexey Proskuryakov
Comment 5
2023-05-31 08:41:17 PDT
This caused many assertion failures, reverting. E.g.
https://build.webkit.org/results/Apple-Ventura-Debug-AppleSilicon-WK1-Tests/264701@main%20(2423)/results.html
DFG ASSERTION FAILED: AI-clobberize disagreement; AI says ClobberedStructures while clobberize says (Direct:[], Super:[]) ./dfg/DFGCFAPhase.cpp(240) : void JSC::DFG::CFAPhase::performBlockCFA(JSC::DFG::BasicBlock *)
Yusuke Suzuki
Comment 6
2023-05-31 09:09:27 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14538
EWS
Comment 7
2023-05-31 17:45:32 PDT
Committed
264768@main
(c602f3ac3760): <
https://commits.webkit.org/264768@main
> Reviewed commits have been landed. Closing PR #14538 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug