Bug 25731 - [Qt] Cleanup - move files exclusive to XPATH and XSLT under the appropriate build section
Summary: [Qt] Cleanup - move files exclusive to XPATH and XSLT under the appropriate b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-12 10:42 PDT by Laszlo Gombos
Modified: 2009-05-15 09:10 PDT (History)
0 users

See Also:


Attachments
Proposed cleanup. (3.97 KB, patch)
2009-05-12 10:45 PDT, Laszlo Gombos
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-05-12 10:42:56 PDT
Benefits:
 - the feature configuration handling for XPATH and XSLT will be consistent with other guards withing Qt port

 - should make builds faster if the feature is disabled
Comment 1 Laszlo Gombos 2009-05-12 10:45:42 PDT
Created attachment 30241 [details]
Proposed cleanup.
Comment 2 Laszlo Gombos 2009-05-12 10:49:57 PDT
Comment on attachment 30241 [details]
Proposed cleanup.

+!contains(DEFINES, ENABLE_XSLT=.): DEFINES += ENABLE_XSLT=0

makes it explicit and more obvious that XSLT is turned off by default for the Qt port (as it was before).
Comment 3 Holger Freyther 2009-05-14 20:33:57 PDT
Comment on attachment 30241 [details]
Proposed cleanup.

Nice.
Comment 4 Eric Seidel (no email) 2009-05-15 00:06:52 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.pro
Committed r43758