WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257307
Update WebRTC abseil to M115
https://bugs.webkit.org/show_bug.cgi?id=257307
Summary
Update WebRTC abseil to M115
youenn fablet
Reported
2023-05-24 23:15:13 PDT
Update WebRTC abseil to M115
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-05-24 23:15:29 PDT
<
rdar://problem/109815455
>
youenn fablet
Comment 2
2023-05-24 23:26:17 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14330
EWS
Comment 3
2023-05-30 23:50:22 PDT
Committed
264715@main
(d388e8ee441d): <
https://commits.webkit.org/264715@main
> Reviewed commits have been landed. Closing PR #14330 and removing active labels.
Diego Pino
Comment 4
2023-06-01 17:51:43 PDT
After abseil update I'm getting the following build error when building WPE using LibWebRTC: ``` CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2101 (add_library): Cannot find source file: Source/third_party/abseil-cpp/absl/synchronization/internal/waiter.cc Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx ``` File 'waiter.cc' does not longer exists after abseil update, but it's still referenced as part of LibWebRTC sources. The build error was not detected by WebKitGTK/WPE EWS bots becasuse by default GStreamer WebRTC is used instead. I don't know why the Apple bots didn't detect this build error.
Diego Pino
Comment 5
2023-06-01 17:52:33 PDT
Re-opening for pull request
https://github.com/webkit/webkit/pull/14611
EWS
Comment 6
2023-06-01 20:16:22 PDT
Committed
264822@main
(c20f9a0705fc): <
https://commits.webkit.org/264822@main
> Reviewed commits have been landed. Closing PR #14611 and removing active labels.
youenn fablet
Comment 7
2023-06-01 22:40:40 PDT
Thanks for spotting it. Mac/iOS bots do not spot it since we are not using cross platform Sources.txt, maybe we should. I expect to update more of libwebrtc third party libraries and libwebrtc itself. Expect some required work on your end to keep making it compile since no EWS bot is checking this config.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug