REOPENED257276
[Xcode] Dependencies in preprocessed sandbox profiles not tracked 
https://bugs.webkit.org/show_bug.cgi?id=257276
Summary [Xcode] Dependencies in preprocessed sandbox profiles not tracked
Elliott Williams
Reported 2023-05-24 12:38:57 PDT
Xcode-based ports use a Makefile to run *.sb.in files through clang, to "preprocess" them and support feature flags and rudimentary includes. This means that files that are included are unknown to the build system, so changes in e.g. "common.sb" do not re-generate the sandbox profiles. Let's move this process over to build rules and emit a discovered dependency file.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-05-24 12:39:17 PDT
<rdar://problem/109790387>
Elliott Williams
Comment 2 2023-05-24 12:42:55 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14302
EWS
Comment 3 2023-05-26 17:07:36 PDT
Committed 264612@main (40fd93b1f2ef): <https://commits.webkit.org/264612@main> Reviewed commits have been landed. Closing PR #14302 and removing active labels.
Elliott Williams
Comment 4 2023-05-30 17:03:26 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/14515
EWS
Comment 5 2023-05-31 11:16:05 PDT
Committed 264744@main (5f13e1c10eb0): <https://commits.webkit.org/264744@main> Reviewed commits have been landed. Closing PR #14515 and removing active labels.
EWS
Comment 6 2023-05-31 13:45:42 PDT
Committed 264752@main (6f04c95bf8f3): <https://commits.webkit.org/264752@main> Reviewed commits have been landed. Closing PR #14553 and removing active labels.
Elliott Williams
Comment 7 2023-06-02 18:40:05 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/14649
EWS
Comment 8 2023-06-06 11:10:45 PDT
Committed 264904@main (c9a65a407c6b): <https://commits.webkit.org/264904@main> Reviewed commits have been landed. Closing PR #14649 and removing active labels.
Elliott Williams
Comment 9 2023-06-07 10:50:18 PDT
Reopening due to revert in https://bugs.webkit.org/show_bug.cgi?id=257814
Note You need to log in before you can comment on or make changes to this bug.