WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257241
[Cocoa] Call [AVCaptureDevice ensureServerConnection] when new extensions are made to the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=257241
Summary
[Cocoa] Call [AVCaptureDevice ensureServerConnection] when new extensions are...
Brent Fulgham
Reported
2023-05-23 16:47:12 PDT
Our current code only calls [AVCaptureDevice ensureServerConnection] the first time we extend the sandbox. This can lead to problems if the user visits a site that only needs Microphone access (for example), and then visits a site that needs Camera access. Because the camera-related extensions are only recognized by the video capture system when [AVCaptureDevice ensureServiceConnection] is called, the fact that we called it before the new sandbox extensions were in place mean we never activate the relevant features. To fix this, we should simply call [AVCaptureDevice ensureServerConnection] any time we extend the sandbox. I have confirmed with the relevant teams that this call is low-cost (performance wise), and is not harmful to call repeatedly for things that have already been activated.
Attachments
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2023-05-23 16:47:38 PDT
<
rdar://109380900
>
Brent Fulgham
Comment 2
2023-05-23 17:04:31 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14276
EWS
Comment 3
2023-05-23 23:06:56 PDT
Committed
264460@main
(fe4af8b17fb6): <
https://commits.webkit.org/264460@main
> Reviewed commits have been landed. Closing PR #14276 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug