RESOLVED FIXED 257233
[baseline-alignment] Rename BaselineContext 
https://bugs.webkit.org/show_bug.cgi?id=257233
Summary [baseline-alignment] Rename BaselineContext
Sammy Gill
Reported 2023-05-23 15:40:42 PDT
Whenever we use BaselineContext for baseline alignment, it is continually modifying its state by inserting items into the appropriate baseline sharing groups. We should remove the "context," portion of this name and rename it to something a bit more appropriate that makes it obvious it is there to help manage the baseline sharing groups in different formatting contexts.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-05-23 15:41:00 PDT
<rdar://problem/109742609>
Sammy Gill
Comment 2 2023-05-23 15:57:31 PDT
Also, a baseline alignment context is something that is part of a specific formatting context. For example, in flex layout the baseline alignment contexts are the flex lines. Based off of that I don't think it's appropriate for a formatting context to "create" an object called BaselineContext
Sammy Gill
Comment 3 2023-05-23 16:39:50 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14271
EWS
Comment 4 2023-05-24 14:23:03 PDT
Committed 264484@main (48c6a9eda4fd): <https://commits.webkit.org/264484@main> Reviewed commits have been landed. Closing PR #14271 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.