Bug 257198 - import-w3c-tests -s doesn't honor skip expectation
Summary: import-w3c-tests -s doesn't honor skip expectation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-23 07:12 PDT by Anne van Kesteren
Modified: 2023-08-21 08:26 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2023-05-23 07:12:27 PDT
In LayoutTests/imported/w3c/resources/import-expectations.json we have:

    "web-platform-tests/websockets": "import",
    "web-platform-tests/websockets/stream": "skip",

However, when I run

    import-w3c-tests web-platform-tests/websockets -l -s ../../Documents/GitHub.nosync --clean-dest-dir

I get everything from the websockets/stream directory anyway.
Comment 1 Radar WebKit Bug Importer 2023-05-30 07:13:15 PDT
<rdar://problem/110004053>
Comment 2 Sam Sneddon [:gsnedders] 2023-08-02 10:11:22 PDT
I can't reproduce this:

```
./Tools/Scripts/import-w3c-tests --clear-dest-dir -t web-platform-tests/websockets
```

Results in:

```
% git status | grep stream
Refresh index: 100% (391489/391489), done.
```
Comment 3 Sam Sneddon [:gsnedders] 2023-08-02 10:11:57 PDT
And removing `"web-platform-tests/websockets/stream": "skip"` does indeed lead it to get imported, so as far as I can tell that is working as expected.
Comment 4 Sam Sneddon [:gsnedders] 2023-08-02 16:22:51 PDT
This still fails to reproduce with `--clear-dest-dir` corrected to `--clean-dest-dir` (bug 259750).
Comment 5 Sam Sneddon [:gsnedders] 2023-08-17 04:11:39 PDT
So, uh, like bug 257674 this only reproduces with `-s`. Well, that's cursed. I love when the simpler codepath is broken.
Comment 6 Sam Sneddon [:gsnedders] 2023-08-17 07:15:03 PDT
Currently, the skip logic in import-expectations.json is implemented in test_downloader.py, and thus is applied during the "download".
Comment 7 Sam Sneddon [:gsnedders] 2023-08-17 07:53:46 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16789
Comment 8 EWS 2023-08-21 08:26:28 PDT
Committed 267088@main (e21f2280dbbb): <https://commits.webkit.org/267088@main>

Reviewed commits have been landed. Closing PR #16789 and removing active labels.