Bug 25716 - Non js test in editing/pasteboard/resources
Summary: Non js test in editing/pasteboard/resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-11 22:13 PDT by Julie Parent
Modified: 2009-05-18 03:22 PDT (History)
1 user (show)

See Also:

Attachments
Convert test into js test. (6.47 KB, patch)
2009-05-11 23:30 PDT, Julie Parent 		no flags Details | Formatted Diff | Diff
Convert test into js test, this time with proper indentation. (6.48 KB, patch)
2009-05-11 23:34 PDT, Julie Parent 		no flags Details | Formatted Diff | Diff
This time, with extra lie breaks! (6.50 KB, patch)
2009-05-12 00:04 PDT, Julie Parent 		eric: review+
Details | Formatted Diff | Diff
New patch, just adds the resource to ignore list (1.16 KB, patch)
2009-05-15 01:00 PDT, Julie Parent 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2009-05-11 22:13:32 PDT 
http://trac.webkit.org/changeset/43255 added LayoutTests/editing/pasteboard/resources/paste-blockquote-before-blockquote.js, which is not a standard js test.

For a change I'm working on, I'm adding some js tests for pasteboard, so I have added a TEMPLATE to LayoutTests/editing/pasteboard/resources.  In order to add my js tests to this directory and run make-js-test-wrappers we'll need to do something about this test.  Seems like the options are to convert it over to be a js test, or to add it to the ignore list in make-js-test-wrappers.

Unless anyone objects, I'll just transform it into a regular js test.
Comment 1 Julie Parent 2009-05-11 23:30:04 PDT 
Created attachment 30219 [details]
Convert test into js test.
Comment 2 Julie Parent 2009-05-11 23:34:34 PDT 
Created attachment 30220 [details]
Convert test into js test, this time with proper indentation.
Comment 3 Julie Parent 2009-05-12 00:04:56 PDT 
Created attachment 30221 [details]
This time, with extra lie breaks!
Comment 4 Eric Seidel (no email) 2009-05-14 21:18:56 PDT 
Comment on attachment 30221 [details]
This time, with extra lie breaks!

Looks fine.
Comment 5 Eric Seidel (no email) 2009-05-14 21:19:30 PDT 
Comment on attachment 30221 [details]
This time, with extra lie breaks!

Looks like your environment still isn't perfect though:
"Julie Jparent"
Comment 6 Eric Seidel (no email) 2009-05-14 21:34:52 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt
	M	LayoutTests/editing/pasteboard/paste-blockquote-before-blockquote.html
	A	LayoutTests/editing/pasteboard/resources/TEMPLATE.html
	M	LayoutTests/editing/pasteboard/resources/paste-blockquote-before-blockquote.js
Committed r43753
Comment 7 Eric Seidel (no email) 2009-05-14 22:19:46 PDT 
Rolled out in:
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	LayoutTests/editing/pasteboard/resources/TEMPLATE.html
	M	LayoutTests/ChangeLog
	M	LayoutTests/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt
	M	LayoutTests/editing/pasteboard/paste-blockquote-before-blockquote.html
	M	LayoutTests/editing/pasteboard/resources/paste-blockquote-before-blockquote.js
Committed r43754


Julie, feel free to re-open if you plan to re-make this change.
Comment 8 Julie Parent 2009-05-15 01:00:53 PDT 
Created attachment 30369 [details]
New patch, just adds the resource to ignore list

New approach -
since resources/paste-blockquote-before-blockquote.js is used for multiple html tests, just ignore this file in make-js-test-wrappers.
Comment 9 Julie Parent 2009-05-15 01:02:03 PDT 
Reopening with new fix to just ignore the file in make-js-test-wrappers instead.
Comment 10 Eric Seidel (no email) 2009-05-16 09:08:18 PDT 
Comment on attachment 30369 [details]
New patch, just adds the resource to ignore list

The bug URL is in kinda a funny place for the ChangeLog.  But this looks fine, will land on Monday.
Comment 11 Eric Seidel (no email) 2009-05-18 03:22:05 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/make-js-test-wrappers
Committed r43820