Bug 257154 - WPT Test (css/css-text/white-space/text-wrap-balance-line-clamp-001.html) triggers assertion failure
Summary: WPT Test (css/css-text/white-space/text-wrap-balance-line-clamp-001.html) tri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-22 14:32 PDT by David Choi
Modified: 2023-05-25 12:04 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.66 KB, patch)
2023-05-22 15:24 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Choi 2023-05-22 14:32:48 PDT
After re-importing css-text/white-space folder from WPT, a new test triggers an assertion failure:

imported/w3c/web-platform-tests/css/css-text/white-space/text-wrap-balance-line-clamp-001.html [ Crash ]

EWS Link: https://ews-build.webkit.org/#/builders/17/builds/5865
Comment 1 Radar WebKit Bug Importer 2023-05-22 14:32:59 PDT
<rdar://problem/109678410>
Comment 2 zalan 2023-05-22 14:52:54 PDT
looks like this assertion needs some adjustment.
Comment 3 zalan 2023-05-22 15:11:28 PDT
yeah in case of block direction overflow handling (e.g. line-clamp) the content on the line does not necessarily overflow in the inline direction -which is what this assert expects.
Comment 4 zalan 2023-05-22 15:24:10 PDT
Created attachment 466454 [details]
Patch
Comment 5 EWS 2023-05-25 12:03:59 PDT
Committed 264532@main (17367cc8c3e0): <https://commits.webkit.org/264532@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466454 [details].