Bug 25708 - Cannot choose menu items in popups with many entries in Chromium
Summary: Cannot choose menu items in popups with many entries in Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Paul Godavari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-11 17:10 PDT by Paul Godavari
Modified: 2009-05-12 14:54 PDT (History)
0 users

See Also:


Attachments
Fix Mac popup item selection for menus with many items (1.97 KB, patch)
2009-05-11 17:28 PDT, Paul Godavari
no flags Details | Formatted Diff | Diff
Fix Mac popup item selection for menus with many items (1.97 KB, patch)
2009-05-11 17:28 PDT, Paul Godavari
dglazkov: review+
Details | Formatted Diff | Diff
Fix Mac popup item selection for menus with many items (corrected spelling in ChangeLog) (2.03 KB, patch)
2009-05-12 14:38 PDT, Paul Godavari
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Godavari 2009-05-11 17:10:40 PDT
Popup menus that contain many entries cannot select menu items beyond the ~20th one in Mac Chromium.

Chromium on Mac uses cocoa controls for handling these popups, and converts the index of the selected item to a coordinate corresponding to that item in the popup. On Windows and linux, Chromium's popup menu uses a ScrollView that limits the number of visible items to a maximum of 20. Any mouse click outside of that scroll view is discarded.

The hit testing in Mac Chromium needs to account for the fact that native popup controls will display as many items as can fit on the screen, which is much more than the artificial limit of 20 that Chromium imposes.
Comment 1 Paul Godavari 2009-05-11 17:28:07 PDT
Created attachment 30208 [details]
Fix Mac popup item selection for menus with many items
Comment 2 Paul Godavari 2009-05-11 17:28:52 PDT
Created attachment 30209 [details]
Fix Mac popup item selection for menus with many items
Comment 3 Dimitri Glazkov (Google) 2009-05-12 09:27:37 PDT
Comment on attachment 30209 [details]
Fix Mac popup item selection for menus with many items


> +        Bug 25708: Cannont choose menu items in popups with many entries in Chromium

Spelling: Cannot.
Comment 4 Paul Godavari 2009-05-12 14:38:00 PDT
Created attachment 30247 [details]
Fix Mac popup item selection for menus with many items (corrected spelling in ChangeLog)
Comment 5 Dimitri Glazkov (Google) 2009-05-12 14:54:44 PDT
Landed as http://trac.webkit.org/changeset/43587.