25705 – Need changes for new Skia API

Bug 25705 - Need changes for new Skia API

Summary: Need changes for new Skia API

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC Windows XP

Importance:	P2 Normal
Assignee:	Stephen White

URL:
Keywords:

Depends on:
Blocks:

Reported:	2009-05-11 14:10 PDT by Stephen White
Modified:	2009-05-12 13:36 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
Changes for new Skia API. (3.31 KB, patch) 2009-05-11 14:13 PDT, Stephen White	dglazkov: review+	Details \| Formatted Diff \| Diff
Take two, compatible with both versions of skia. (4.08 KB, patch) 2009-05-12 11:33 PDT, Stephen White	dglazkov: review+	Details \| Formatted Diff \| Diff
Take three: FIXME instead of TODO(senorblanco) (4.09 KB, patch) 2009-05-12 13:23 PDT, Stephen White	dglazkov: review+	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stephen White 2009-05-11 14:10:51 PDT

There are some slight API changes in the new version of skia which require 
changes to WebKit.  Only affects Chromium.

Comment 1 Stephen White 2009-05-11 14:13:05 PDT

Created attachment 30203 [details]
Changes for new Skia API.

Comment 2 Dimitri Glazkov (Google) 2009-05-12 09:14:17 PDT

Comment on attachment 30203 [details]
Changes for new Skia API.

Don't forget the URL of the bug in the ChangeLog entry next time.

Comment 3 Stephen White 2009-05-12 11:33:07 PDT

Created attachment 30245 [details]
Take two, compatible with both versions of skia.

Comment 4 Stephen White 2009-05-12 11:33:47 PDT

On second thought, better to hide these changes behind an #ifdef for now, so we
don't kill the canary.  :)

Comment 5 Dimitri Glazkov (Google) 2009-05-12 12:11:16 PDT

Comment on attachment 30245 [details]
Take two, compatible with both versions of skia.

even betterer.

Comment 6 Dimitri Glazkov (Google) 2009-05-12 12:12:11 PDT

Oh -- one thing. Can you replace TODO(senorblanco) with FIXME, to match WebKit style?

Comment 7 Dimitri Glazkov (Google) 2009-05-12 12:13:07 PDT

And please add me to cc of bugs. Asking for review is like a one-time shot -- it doesn't let the reviewer to listen in on the conversation on the bug (if any).

Comment 8 Stephen White 2009-05-12 13:23:33 PDT

Created attachment 30246 [details]
Take three:  FIXME instead of TODO(senorblanco)

Comment 9 Dimitri Glazkov (Google) 2009-05-12 13:24:33 PDT

Comment on attachment 30246 [details]
Take three:  FIXME instead of TODO(senorblanco)

Great!

Comment 10 Stephen White 2009-05-12 13:27:27 PDT

(In reply to comment #7)
> And please add me to cc of bugs. Asking for review is like a one-time shot --
> it doesn't let the reviewer to listen in on the conversation on the bug (if
> any).
> 

Will do.  (I assume you mean "in the future, I did it this time" since I see your name in the CC list already).

Comment 11 Dimitri Glazkov (Google) 2009-05-12 13:32:16 PDT

I added myself :)

Comment 12 Dimitri Glazkov (Google) 2009-05-12 13:36:55 PDT

Landed as http://trac.webkit.org/changeset/43584.