WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
25705
Need changes for new Skia API
https://bugs.webkit.org/show_bug.cgi?id=25705
Summary
Need changes for new Skia API
Stephen White
Reported
2009-05-11 14:10:51 PDT
There are some slight API changes in the new version of skia which require changes to WebKit. Only affects Chromium.
Attachments
Changes for new Skia API.
(3.31 KB, patch)
2009-05-11 14:13 PDT
,
Stephen White
dglazkov
: review+
Details
Formatted Diff
Diff
Take two, compatible with both versions of skia.
(4.08 KB, patch)
2009-05-12 11:33 PDT
,
Stephen White
dglazkov
: review+
Details
Formatted Diff
Diff
Take three: FIXME instead of TODO(senorblanco)
(4.09 KB, patch)
2009-05-12 13:23 PDT
,
Stephen White
dglazkov
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Stephen White
Comment 1
2009-05-11 14:13:05 PDT
Created
attachment 30203
[details]
Changes for new Skia API.
Dimitri Glazkov (Google)
Comment 2
2009-05-12 09:14:17 PDT
Comment on
attachment 30203
[details]
Changes for new Skia API. Don't forget the URL of the bug in the ChangeLog entry next time.
Stephen White
Comment 3
2009-05-12 11:33:07 PDT
Created
attachment 30245
[details]
Take two, compatible with both versions of skia.
Stephen White
Comment 4
2009-05-12 11:33:47 PDT
On second thought, better to hide these changes behind an #ifdef for now, so we don't kill the canary. :)
Dimitri Glazkov (Google)
Comment 5
2009-05-12 12:11:16 PDT
Comment on
attachment 30245
[details]
Take two, compatible with both versions of skia. even betterer.
Dimitri Glazkov (Google)
Comment 6
2009-05-12 12:12:11 PDT
Oh -- one thing. Can you replace TODO(senorblanco) with FIXME, to match WebKit style?
Dimitri Glazkov (Google)
Comment 7
2009-05-12 12:13:07 PDT
And please add me to cc of bugs. Asking for review is like a one-time shot -- it doesn't let the reviewer to listen in on the conversation on the bug (if any).
Stephen White
Comment 8
2009-05-12 13:23:33 PDT
Created
attachment 30246
[details]
Take three: FIXME instead of TODO(senorblanco)
Dimitri Glazkov (Google)
Comment 9
2009-05-12 13:24:33 PDT
Comment on
attachment 30246
[details]
Take three: FIXME instead of TODO(senorblanco) Great!
Stephen White
Comment 10
2009-05-12 13:27:27 PDT
(In reply to
comment #7
)
> And please add me to cc of bugs. Asking for review is like a one-time shot -- > it doesn't let the reviewer to listen in on the conversation on the bug (if > any). >
Will do. (I assume you mean "in the future, I did it this time" since I see your name in the CC list already).
Dimitri Glazkov (Google)
Comment 11
2009-05-12 13:32:16 PDT
I added myself :)
Dimitri Glazkov (Google)
Comment 12
2009-05-12 13:36:55 PDT
Landed as
http://trac.webkit.org/changeset/43584
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug