Bug 25702 - Unregister plugins when they are stopped, in Qt port
Summary: Unregister plugins when they are stopped, in Qt port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-11 12:53 PDT by Yael
Modified: 2009-05-11 22:08 PDT (History)
0 users

See Also:


Attachments
Add call to unregister the plugin when it is stopped (1.40 KB, patch)
2009-05-11 12:55 PDT, Yael
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2009-05-11 12:53:06 PDT
Plugins are registered with PluginMainThreadScheduler when they are started, but in Qt port, they are not unregistered when they are stopped. This can lead to an assertion failure in PluginMainThreadScheduler::registerPlugin if the same address is reused for a new NPP instance.
Comment 1 Yael 2009-05-11 12:55:01 PDT
Created attachment 30200 [details]
Add call to unregister the plugin when it is stopped
Comment 2 Holger Freyther 2009-05-11 20:48:07 PDT
Comment on attachment 30200 [details]
Add call to unregister the plugin when it is stopped

Same fix is needed for Gtk+ :)
Comment 3 Holger Freyther 2009-05-11 22:08:22 PDT
Windows is doing it below the "Clear Window" but I assume it is okay, landed in r43550.