Bug 25697 - [GTK] Warnings building WebKit/gtk/tests/testwebframe.c
Summary: [GTK] Warnings building WebKit/gtk/tests/testwebframe.c
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/builders/GTK%...
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-11 10:00 PDT by David Kilzer (:ddkilzer)
Modified: 2009-05-11 17:58 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2009-05-11 10:00:00 PDT 
* SUMMARY
There are compilation warnings building WebKit/gtk/tests/testwebframe.c:

../../WebKit/gtk/tests/testwebframe.c:45: warning: passing argument 2 of 'gtk_container_add' from incompatible pointer type
../../WebKit/gtk/tests/testwebframe.c:47: warning: passing argument 1 of 'gtk_widget_show' from incompatible pointer type
../../WebKit/gtk/tests/testwebframe.c:48: warning: passing argument 1 of 'gtk_widget_destroy' from incompatible pointer type

It appears that all of these methods want a GtkWidget* argument where the WebKitWebView* webView variable is used.
Comment 1 Christian Dywan 2009-05-11 17:50:20 PDT 
2009-05-11  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25697
        [GTK] Warnings building WebKit/gtk/tests/testwebframe.c

        * tests/testwebframe.c:
        (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget*
        to fix pointer type incompatibility warnings.
Comment 2 David Kilzer (:ddkilzer) 2009-05-11 17:58:40 PDT 
Thanks!!  http://trac.webkit.org/changeset/43530