RESOLVED FIXED 256957
Partial Sync 'SVGPoint' interface based on WebIDL Spec 
https://bugs.webkit.org/show_bug.cgi?id=256957
Summary Partial Sync 'SVGPoint' interface based on WebIDL Spec
Ahmad Saleem
Reported 2023-05-18 04:14:56 PDT
Hi Team, While going through failing WPT tests, I noticed that we fail following test: WPT Test: https://wpt.fyi/results/svg/types/scripted/SVGPoint.html?label=experimental&label=master&aligned Test Link: http://wpt.live/svg/types/scripted/SVGPoint.html Web-Spec: https://www.w3.org/TR/SVG11/coords.html#InterfaceSVGPoint WebKit Source: https://github.com/WebKit/WebKit/blob/72a5da6f76c149467b984101d948efca3753ac71/Source/WebCore/svg/SVGPoint.idl#L27 We have 'unrestricted' and removing it by matching spec, we pass above testcase. ____ It will fail following (which needs to be rebaselined): svg/dom/SVGPoint.html I see failures in following two WPT tests: SVGGeometryElement.isPointInStroke-01.svg SVGGeometryElement.isPointInFill-01.svg ^ These could be due to my other patches but could be due to SVGPoint.idl changes. Although running these tests via MiniBrowser one by one does not show any failure. So it might be that we have outdated tests in our repo compared to WPT. Just wanted to highlight. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-05-25 04:15:27 PDT
<rdar://problem/109826265>
Ahmad Saleem
Comment 2 2023-10-17 16:22:29 PDT
NOTE - WPT failures are false positive and it is due to our WPT sync being too old. I am doing WPT sync here and later I will try to fix this as well: https://github.com/WebKit/WebKit/pull/19188
EWS
Comment 3 2023-10-20 00:11:42 PDT
Committed 269558@main (b75cd6787636): <https://commits.webkit.org/269558@main> Reviewed commits have been landed. Closing PR #19288 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.