RESOLVED FIXED256937
[css-flexbox][baseline-alignment] Flex item's with different writing mode from flex container should not always synthesize a baseline 
https://bugs.webkit.org/show_bug.cgi?id=256937
Summary [css-flexbox][baseline-alignment] Flex item's with different writing mode fro...
Sammy Gill
Reported 2023-05-17 17:53:09 PDT
Created attachment 466390 [details] Testcase Flex layout will call into a flex item's firstLineBaseline/lastLineBaseline in order to compute an ascent for the item to use in baseline alignment. If the flex item has a different writing mode from the flex container then it will return std::nullopt because of the check for isWritingModeRoot() and as a result will have a baseline synthesized. In the attached test case (reduced from css-flexbox/alignment/flex-align-baseline-001.html) we should still be able to compute baseline values for the flex items since the block axis for the items is parallel to the alignment context.
Attachments
Testcase (710 bytes, text/html)
2023-05-17 17:53 PDT, Sammy Gill 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-05-17 17:53:32 PDT
<rdar://problem/109489182>
Sammy Gill
Comment 2 2023-05-19 15:38:02 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14108
Sammy Gill
Comment 3 2023-05-22 21:50:09 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/40153
EWS
Comment 4 2023-05-23 10:18:58 PDT
Committed 264423@main (2c62617577b6): <https://commits.webkit.org/264423@main> Reviewed commits have been landed. Closing PR #14108 and removing active labels.
Sammy Gill
Comment 5 2023-12-20 14:50:08 PST
*** Bug 247640 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.