Bug 256893 - Make sure to run a service worker before firing its activate event
Summary: Make sure to run a service worker before firing its activate event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-17 06:27 PDT by youenn fablet
Modified: 2023-06-25 15:10 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2023-05-17 06:27:14 PDT 
Make sure to run a service worker before firing its activate event
Comment 1 youenn fablet 2023-05-17 06:27:31 PDT 
<rdar://109411104>
Comment 2 youenn fablet 2023-05-17 06:37:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13961
Comment 3 EWS 2023-05-19 02:07:36 PDT 
Committed 264242@main (ff4eced3ff23): <https://commits.webkit.org/264242@main>

Reviewed commits have been landed. Closing PR #13961 and removing active labels.
Comment 4 Thomas Wisniewski [:twisniewski] 2023-06-07 14:09:09 PDT 
Has the new WPT in this patch been sent to be synced upstream? I'm not seeing it on wpt.fyi or wpt.live.
Comment 5 Thomas Wisniewski [:twisniewski] 2023-06-07 14:16:51 PDT 
(I also note that `withIframe` isn't defined in the test itself, so it would be good to fix that before sending a PR).
Comment 6 youenn fablet 2023-06-13 06:22:12 PDT 
(In reply to Thomas Wisniewski [:twisniewski] from comment #4)
> Has the new WPT in this patch been sent to be synced upstream? I'm not
> seeing it on wpt.fyi or wpt.live.

The test is in LayoutTests/http/wpt so it is separate from wpt.fyi.
I guess we could upstream it though to help other browsers.
Would that be of interest?

withIFrame is defined in a JS file in wpt repo.
Comment 7 Thomas Wisniewski [:twisniewski] 2023-06-13 06:47:15 PDT 
Ah I see, thanks for the explanation!

Yes, it would be great to have as much coverage in WPTs as possible instead of browser-specific test infrastructure, so that we can all ensure interop. Even where it isn't currently possible (due to lacking low-level APIs and such), it would be good to let the WPT team know what's missing to make it possible eventually.

This doesn't have to be a high priority of course, but every little bit helps (especially with interop202x [1] being a thing; the better our coverage now, the less likely service workers will become a future focus area in that project).