Bug 25684 - ScrollView::valueChanged compares the parameter pointer with m_verticalScrollbar/m_horizontalScrollbar
Summary: ScrollView::valueChanged compares the parameter pointer with m_verticalScroll...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Holger Freyther
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-10 22:48 PDT by Holger Freyther
Modified: 2009-05-22 22:48 PDT (History)
0 users

See Also:


Attachments
Use Scrollbar::orientation to get the orientation (1.75 KB, patch)
2009-05-10 22:49 PDT, Holger Freyther
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2009-05-10 22:48:12 PDT
While fixing a bug on GTK+ I noticed that ScrollView::valueChanged is using pointers to figure out the direction/axis of the scrolling. I couldn't find any reason for that, hence writing a bug report.
Comment 1 Holger Freyther 2009-05-10 22:49:03 PDT
Created attachment 30173 [details]
Use Scrollbar::orientation to get the orientation

Why wasn't Scrollbar::orientation used for this? Is there any reason?
Comment 2 Maciej Stachowiak 2009-05-22 01:01:31 PDT
Comment on attachment 30173 [details]
Use Scrollbar::orientation to get the orientation

r=me
Comment 3 Holger Freyther 2009-05-22 22:48:19 PDT
Landed in r44079.