Bug 256811 – textareas logical height with overflow auto shouldn't add scrollbar-thickness

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Luke Warlow]

Currently in WebKit if a textarea has overflow auto and overflow-wrap normal, it includes the scrollbar thickness in the logical height. This check doesn't exist in Firefox and no longer exists in Chrome as of https://chromium.googlesource.com/chromium/src/+/18481ffa332076e58fd9adbbea2062c2ba087dfb

It would be good to remove it from WebKit too for interop purposes.


if ((isHorizontalWritingMode() && (style().overflowX() == Overflow::Scroll ||  (style().overflowX() == Overflow::Auto && innerText->renderer()->style().overflowWrap() == OverflowWrap::Normal)))
    || (!isHorizontalWritingMode() && (style().overflowY() == Overflow::Scroll ||  (style().overflowY() == Overflow::Auto && innerText->renderer()->style().overflowWrap() == OverflowWrap::Normal))))
    logicalHeight += scrollbarThickness();

The above code inside of RenderTextControl.cpp would become something like the below code:

if ((isHorizontalWritingMode() && style().overflowX() == Overflow::Scroll)
    || (!isHorizontalWritingMode() && style().overflowY() == Overflow::Scroll))
    logicalHeight += scrollbarThickness();

[Radar WebKit Bug Importer]

<rdar://problem/109384976>

[zalan]

Created attachment 466393 [details]
Patch

[zalan]

Created attachment 466398 [details]
Patch

[zalan]

Created attachment 466399 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 466399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466399&action=review

> COMMIT_MESSAGE:7
> +Merged from Blink: https://chromium.googlesource.com/chromium/src/+/18481ffa332076e58fd9adbbea2062c2ba087dfb

I would like some more words here, explaining when we get a behavior change.

> COMMIT_MESSAGE:14
> +* LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt: WebKit matches Chrome now.

Don't care if it matches Chrome :)

[zalan]

Created attachment 466416 [details]
Patch

[EWS]

Committed 264251@main (8b48b8b9e8b8): <https://commits.webkit.org/264251@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466416 [details].