Bug 256778 - ImageBufferBackend::getPixelBuffer has redundant allocator parameter
Summary: ImageBufferBackend::getPixelBuffer has redundant allocator parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-15 01:44 PDT by Kimmo Kinnunen
Modified: 2023-05-19 01:35 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2023-05-15 01:44:37 PDT 
ImageBufferBackend::getPixelBuffer has redundant allocator parameter

ImageBufferBackend::getPixelBuffer is a virtual function where subclasses can customize the behavior.
The PixelBuffer allocator parameter is not used in polymorphic way. Instead, the caller of ImageBufferBackend::getImageBuffer, e.g. ImageBuffer and RemoteImageBufferProxy, can create the PixelBuffer before invoking getPixelBuffer.
Comment 1 Radar WebKit Bug Importer 2023-05-15 01:45:04 PDT 
<rdar://problem/109343550>
Comment 2 Kimmo Kinnunen 2023-05-15 01:59:44 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13870
Comment 3 EWS 2023-05-19 01:35:20 PDT 
Committed 264239@main (61e0dd7d8d87): <https://commits.webkit.org/264239@main>

Reviewed commits have been landed. Closing PR #13870 and removing active labels.