RESOLVED FIXED 256778
ImageBufferBackend::getPixelBuffer has redundant allocator parameter 
https://bugs.webkit.org/show_bug.cgi?id=256778
Summary ImageBufferBackend::getPixelBuffer has redundant allocator parameter
Kimmo Kinnunen
Reported 2023-05-15 01:44:37 PDT
ImageBufferBackend::getPixelBuffer has redundant allocator parameter ImageBufferBackend::getPixelBuffer is a virtual function where subclasses can customize the behavior. The PixelBuffer allocator parameter is not used in polymorphic way. Instead, the caller of ImageBufferBackend::getImageBuffer, e.g. ImageBuffer and RemoteImageBufferProxy, can create the PixelBuffer before invoking getPixelBuffer.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-05-15 01:45:04 PDT
<rdar://problem/109343550>
Kimmo Kinnunen
Comment 2 2023-05-15 01:59:44 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13870
EWS
Comment 3 2023-05-19 01:35:20 PDT
Committed 264239@main (61e0dd7d8d87): <https://commits.webkit.org/264239@main> Reviewed commits have been landed. Closing PR #13870 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.