Bug 256751 - import-w3c-tests does not remove upstream removals
Summary: import-w3c-tests does not remove upstream removals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
: 231183 (view as bug list)
Depends on:
Blocks: 235038
  Show dependency tree / graph
 
Reported: 2023-05-13 00:28 PDT by Anne van Kesteren
Modified: 2023-05-31 13:35 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2023-05-13 00:28:03 PDT 
Because of this we appear to sometimes run old tests. It seems that before importing you first have to clear a directory.
Comment 1 Sam Sneddon [:gsnedders] 2023-05-16 10:01:49 PDT 
`--clean-dest-dir` should do this, except it doesn't work if you're doing a partial import (it removes everything outside of the partial import!).

That was fixed in bug 235038 (which never landed because writing a unit test kept throwing up more failures), so let's keep this open to deal with landing that (split out from the rest of the changes there).
Comment 2 Radar WebKit Bug Importer 2023-05-16 10:02:04 PDT 
<rdar://problem/109410621>
Comment 3 Sam Sneddon [:gsnedders] 2023-05-16 10:48:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13929
Comment 4 EWS 2023-05-22 16:10:25 PDT 
Committed 264384@main (348235605fd9): <https://commits.webkit.org/264384@main>

Reviewed commits have been landed. Closing PR #13929 and removing active labels.
Comment 5 Sam Sneddon [:gsnedders] 2023-05-31 13:35:43 PDT 
*** Bug 231183 has been marked as a duplicate of this bug. ***