WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
256724
[WebGPU][WGSL] sampling a texture_external should expand to two samples
https://bugs.webkit.org/show_bug.cgi?id=256724
Summary
[WebGPU][WGSL] sampling a texture_external should expand to two samples
Mike Wyrzykowski
Reported
2023-05-12 11:27:07 PDT
In WGSL if we have: texture_external t; vec4<f32> result = textureSampleBaseClampToEdge(t, sampler, normalizedCoordinates); or: texture_external t; vec4<f32> result = textureLoad(t, pixelCoordinates, levelOfDetail); we should expand this to: auto coords = t_UVRemapMatrix * normalizedCoordinates; auto y = t_FirstPlane.sample(sampler, coords).r; auto cbcr = t_SecondPlane.sample(sampler, coords).rg; auto ycbcr = float3(y, cbcr); float4 result = float4(t_ColorSpaceConversionMatrix * float4(ycbcr, 1), 1); or: auto coords = t_UVRemapMatrix * pixelCoordinates; auto y = t_FirstPlane.read(coords, levelOfDetail).r; auto cbcr = t_SecondPlane.read(sampler, levelOfDetail).rg; auto ycbcr = float3(y, cbcr); float4 result = float4(t_ColorSpaceConversionMatrix * float4(ycbcr, 1), 1);
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-05-12 11:27:32 PDT
<
rdar://problem/109273173
>
Tadeu Zagallo
Comment 2
2023-05-16 05:49:50 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/13916
EWS
Comment 3
2023-05-17 02:52:00 PDT
Committed
264141@main
(6c82c6b0b152): <
https://commits.webkit.org/264141@main
> Reviewed commits have been landed. Closing PR #13916 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug