Bug 256702 - Resolve percentage in <use> against the instance's viewport element
Summary: Resolve percentage in <use> against the instance's viewport element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: https://jsfiddle.net/v9qkt4rf/
Keywords: InRadar
: 128589 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-05-12 07:06 PDT by Ahmad Saleem
Modified: 2023-06-01 12:24 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-05-12 07:06:13 PDT
Hi Team,

While going through Blink's commit, I came across another potential merge to fix another failing test (in the URL field).

Blink Commit - https://chromium.googlesource.com/chromium/src/+/b34ff6fe2d5842a63e2c66f68f050f0cf9163010

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/LegacyRenderSVGTransformableContainer.cpp#61

I don't know how to fix LBSE so I think till we don't have LBSE enabled, we can still fix it in Legacy.

Just wanted to raise so we can fix it. (It might not be single merge, because we have 'bool' function while it is different in Blink).

Thanks!
Comment 1 Ahmad Saleem 2023-05-13 13:44:36 PDT
(In reply to Ahmad Saleem from comment #0)
> Hi Team,
> 
> While going through Blink's commit, I came across another potential merge to
> fix another failing test (in the URL field).
> 
> Blink Commit -
> https://chromium.googlesource.com/chromium/src/+/
> b34ff6fe2d5842a63e2c66f68f050f0cf9163010
> 
> WebKit Source -
> https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/
> LegacyRenderSVGTransformableContainer.cpp#61
> 
> I don't know how to fix LBSE so I think till we don't have LBSE enabled, we
> can still fix it in Legacy.
> 
> Just wanted to raise so we can fix it. (It might not be single merge,
> because we have 'bool' function while it is different in Blink).
> 
> Thanks!

Doing this leads to following error:

'no matching constructor for initialization of 'WebCore::SVGLengthContext''.
Comment 2 Radar WebKit Bug Importer 2023-05-19 07:07:19 PDT
<rdar://problem/109565397>
Comment 3 EWS 2023-05-26 11:03:53 PDT
Committed 264596@main (590f8fce92df): <https://commits.webkit.org/264596@main>

Reviewed commits have been landed. Closing PR #14160 and removing active labels.
Comment 4 Said Abou-Hallawa 2023-06-01 12:24:06 PDT
*** Bug 128589 has been marked as a duplicate of this bug. ***