Bug 256675 - Use system malloc when MallocStackLogging is enabled
Summary: Use system malloc when MallocStackLogging is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-11 16:40 PDT by Ben Nham
Modified: 2023-05-15 09:24 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2023-05-11 16:40:50 PDT 
In 255601@main we added support for MallocStackLogging in libpas. This seems to work when using Instruments, but doesn't seem to work when capturing memgraphs. Since memgraphs are the most common way that other teams pass memory regression bugs to us, it's important that capturing stacks via memgraphs works by default. This change makes MallocStackLogging imply using system malloc so that stacks in memgraphs are present. You can still force MallocStackLogging with libpas by using MallocStackLogging=lite NO_DEBUG_HEAP=1 after this patch.
Comment 1 Ben Nham 2023-05-11 16:40:58 PDT 
<rdar://problem/109233872>
Comment 2 Ben Nham 2023-05-11 16:43:27 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13783
Comment 3 EWS 2023-05-15 09:24:48 PDT 
Committed 264075@main (b6454a5cd58f): <https://commits.webkit.org/264075@main>

Reviewed commits have been landed. Closing PR #13783 and removing active labels.