WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
256675
Use system malloc when MallocStackLogging is enabled
https://bugs.webkit.org/show_bug.cgi?id=256675
Summary
Use system malloc when MallocStackLogging is enabled
Ben Nham
Reported
2023-05-11 16:40:50 PDT
In
255601@main
we added support for MallocStackLogging in libpas. This seems to work when using Instruments, but doesn't seem to work when capturing memgraphs. Since memgraphs are the most common way that other teams pass memory regression bugs to us, it's important that capturing stacks via memgraphs works by default. This change makes MallocStackLogging imply using system malloc so that stacks in memgraphs are present. You can still force MallocStackLogging with libpas by using MallocStackLogging=lite NO_DEBUG_HEAP=1 after this patch.
Attachments
Add attachment
proposed patch, testcase, etc.
Ben Nham
Comment 1
2023-05-11 16:40:58 PDT
<
rdar://problem/109233872
>
Ben Nham
Comment 2
2023-05-11 16:43:27 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/13783
EWS
Comment 3
2023-05-15 09:24:48 PDT
Committed
264075@main
(b6454a5cd58f): <
https://commits.webkit.org/264075@main
> Reviewed commits have been landed. Closing PR #13783 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug