WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
256598
AX: Cache relative frame for ScrollView and WebArea during page load in the IsolatedObject.
https://bugs.webkit.org/show_bug.cgi?id=256598
Summary
AX: Cache relative frame for ScrollView and WebArea during page load in the I...
Andres Gonzalez
Reported
2023-05-10 11:25:27 PDT
Not doing so causes a hit on the main thread while busy building the isolated tree.
Attachments
Patch
(2.34 KB, patch)
2023-05-10 11:34 PDT
,
Andres Gonzalez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-05-10 11:25:40 PDT
<
rdar://problem/109162963
>
Andres Gonzalez
Comment 2
2023-05-10 11:34:02 PDT
Created
attachment 466308
[details]
Patch
Tyler Wilcock
Comment 3
2023-05-10 11:45:07 PDT
Comment on
attachment 466308
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=466308&action=review
> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:177 > + setProperty(AXPropertyName::RelativeFrame, IntRect { object.relativeFrame() });
We use `enclosingIntRect(...)` when caching the paint rects, so let's use that over IntRect { ... } here too.
EWS
Comment 4
2023-05-10 16:46:09 PDT
Committed
263938@main
(a10c2f6a130d): <
https://commits.webkit.org/263938@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 466308
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug