RESOLVED FIXED 25656
Reduce the size of CSSParserValueList 
https://bugs.webkit.org/show_bug.cgi?id=25656
Summary Reduce the size of CSSParserValueList
Simon Fraser (smfr)
Reported 2009-05-08 16:56:46 PDT
CSSParserValueList is 544 bytes in 64-bit, and accounts for about 2.4MB of churn when running the PLTs. I think the vector of m_values can uses a smaller initial buffer size.
Attachments
Patch, changelog (1020 bytes, patch)
2009-05-08 17:20 PDT, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-05-08 17:03:51 PDT
I browsed some common sites, and the frequency distribution of the high water mark of the m_values size is: 1 20717 2 864 3 1166 4 1380 5 293 6 121 7 26 8 8 9 9 10 2 11 2 12 7 13 1 So a size of 4 will include 98% of cases.
Simon Fraser (smfr)
Comment 2 2009-05-08 17:20:13 PDT
Created attachment 30149 [details] Patch, changelog I ran the PLTs with this patch, and was not able to detect any performance decrease.
Simon Fraser (smfr)
Comment 3 2009-05-08 17:53:42 PDT
http://trac.webkit.org/changeset/43423
Note You need to log in before you can comment on or make changes to this bug.