Bug 256553 - ResizeObserver: Fix node depth computation for shadow nodes
Summary: ResizeObserver: Fix node depth computation for shadow nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks: 148695
  Show dependency tree / graph
 
Reported: 2023-05-09 14:56 PDT by Ahmad Saleem
Modified: 2023-05-10 12:39 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-05-09 14:56:10 PDT 
Hi Team,

While going through WPT failing in Safari / WebKit, I came across following test, which is failing in WebKit only:

Test Link - http://wpt.live/resize-observer/calculate-depth-for-node.html

Blink Commit - https://chromium.googlesource.com/chromium/src/+/2b6f3f4bfda3b1326b15a956d06a6e3c5f0bb362

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/page/ResizeObservation.cpp#145

Web-Spec: https://github.com/w3c/csswg-drafts/pull/3945

Just wanted to raise, so this can be fixed.

Thanks!
Comment 1 Ryosuke Niwa 2023-05-10 02:07:33 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13687
Comment 2 EWS 2023-05-10 12:38:27 PDT 
Committed 263920@main (495d920632fd): <https://commits.webkit.org/263920@main>

Reviewed commits have been landed. Closing PR #13687 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-05-10 12:39:20 PDT 
<rdar://problem/109166329>