Bug 256537 - [Repaint] Cleanup RenderElement::repaintAfterLayoutIfNeeded
Summary: [Repaint] Cleanup RenderElement::repaintAfterLayoutIfNeeded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 251176
  Show dependency tree / graph
 
Reported: 2023-05-09 11:36 PDT by zalan
Modified: 2023-05-09 19:33 PDT (History)
10 users (show)

See Also:

Attachments
Patch (19.72 KB, patch)
2023-05-09 12:21 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (19.61 KB, patch)
2023-05-09 12:29 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (19.69 KB, patch)
2023-05-09 16:01 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-05-09 11:36:39 PDT 
ssia
Comment 1 zalan 2023-05-09 12:21:31 PDT 
Created attachment 466296 [details]
Patch
Comment 2 zalan 2023-05-09 12:29:16 PDT 
Created attachment 466297 [details]
Patch
Comment 3 Simon Fraser (smfr) 2023-05-09 14:07:59 PDT 
Comment on attachment 466297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466297&action=review

> Source/WebCore/rendering/RenderElement.cpp:1287
> +    auto width = absoluteValue(newOutlineAndBoxShadowBox.width() - oldOutlineAndBoxShadowBox.width());

Nicer to compute a size delta  (with "delta" in the name).
Comment 4 zalan 2023-05-09 15:24:11 PDT 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 466297 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466297&action=review
> 
> > Source/WebCore/rendering/RenderElement.cpp:1287
> > +    auto width = absoluteValue(newOutlineAndBoxShadowBox.width() - oldOutlineAndBoxShadowBox.width());
> 
> Nicer to compute a size delta  (with "delta" in the name).
Good point!
Comment 5 zalan 2023-05-09 16:01:27 PDT 
Created attachment 466300 [details]
Patch
Comment 6 EWS 2023-05-09 19:32:33 PDT 
Committed 263890@main (e10f145ce649): <https://commits.webkit.org/263890@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466300 [details].
Comment 7 Radar WebKit Bug Importer 2023-05-09 19:33:19 PDT 
<rdar://problem/109131286>