Bug 25653 - PLATFORM(X86_64) inherits ia64
Summary: PLATFORM(X86_64) inherits ia64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-08 15:51 PDT by Sebastian
Modified: 2009-05-09 09:01 PDT (History)
0 users

See Also:


Attachments
fix patch (1.06 KB, patch)
2009-05-08 15:52 PDT, Sebastian
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian 2009-05-08 15:51:17 PDT
which is wrong because there are complete different
Comment 1 Sebastian 2009-05-08 15:52:50 PDT
Created attachment 30145 [details]
fix patch
Comment 2 Gustavo Noronha (kov) 2009-05-09 08:09:49 PDT
Comment on attachment 30145 [details]
fix patch

> diff --git a/JavaScriptCore/wtf/Platform.h b/JavaScriptCore/wtf/Platform.h
> index 59f8b8f..6e4eae4 100644
> --- a/JavaScriptCore/wtf/Platform.h
> +++ b/JavaScriptCore/wtf/Platform.h
> @@ -220,7 +220,6 @@
>  
>  /* PLATFORM(X86_64) */
>  #if   defined(__x86_64__) \
> -   || defined(__ia64__) \
>     || defined(_M_X64)
>  #define WTF_PLATFORM_X86_64 1
>  #endif
> -- 
> 1.6.2.4
> 

I'll r+ and commit this patch, since the fix is quite obvious as you said. For future patches, please include a proper ChangeLog entry as described in http://webkit.org/coding/contributing.html.
Comment 3 Gustavo Noronha (kov) 2009-05-09 09:01:27 PDT
Landed as r43440.