Bug 256440 - REGRESSION (251295@main): -[WKWebInspectorUISaveController initWithSaveDatas:savePanel:] leaks an NSView
Summary: REGRESSION (251295@main): -[WKWebInspectorUISaveController initWithSaveDatas:...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 241214
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-07 20:44 PDT by David Kilzer (:ddkilzer)
Modified: 2023-05-08 01:22 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-05-07 20:44:10 PDT 
-[WKWebInspectorUISaveController initWithSaveDatas:savePanel:] leaks an NSView.

Found by clang static analyzer.

Regressed in:

    Web Inspector: replace the two "Export Audit" and "Export Result" buttons with a single button that has a picker in 
the `NSSavePanel`
    https://bugs.webkit.org/show_bug.cgi?id=241214
    <rdar://problem/76775840>
    <https://commits.webkit.org/251295@main>
Comment 1 Radar WebKit Bug Importer 2023-05-07 20:44:39 PDT 
<rdar://problem/109023427>
Comment 2 David Kilzer (:ddkilzer) 2023-05-07 20:48:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13561
Comment 3 EWS 2023-05-08 01:22:32 PDT 
Committed 263787@main (e6f69b44fce6): <https://commits.webkit.org/263787@main>

Reviewed commits have been landed. Closing PR #13561 and removing active labels.