RESOLVED FIXED 256432
Fix false-positive bad release after calling H264BufferToCMSampleBuffer/H265BufferToCMSampleBuffer 
https://bugs.webkit.org/show_bug.cgi?id=256432
Summary Fix false-positive bad release after calling H264BufferToCMSampleBuffer/H265B...
David Kilzer (:ddkilzer)
Reported 2023-05-07 12:16:51 PDT
Fix false-positive bad release after calling H264BufferToCMSampleBuffer() and H265BufferToCMSampleBuffer(). Both of these methods return +1 retained CMSampleBufferRef objects, but are not instrumented with CF_RETURNS_RETAINED, so the clang static analyzer flags in the -decodeData:size:timeStamp: methods of RTCVideoDecoderH264 and RTCVideoDecoderH265.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-05-07 12:17:11 PDT
<rdar://problem/109014853>
David Kilzer (:ddkilzer)
Comment 2 2023-05-07 12:26:36 PDT
Caused by: Add support for AVC H264 WebCodecsVideoDecoder <https://bugs.webkit.org/show_bug.cgi?id=246141> <rdar://problem/100844377> <https://commits.webkit.org/255422@main>
David Kilzer (:ddkilzer)
Comment 3 2023-05-07 12:28:29 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13551
EWS
Comment 4 2023-05-08 06:48:32 PDT
Committed 263800@main (3163f4a6e89a): <https://commits.webkit.org/263800@main> Reviewed commits have been landed. Closing PR #13551 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.