Bug 256428 – [GStreamer][MSE] Decoder sometimes receives caps event before stream-start

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

And that triggers a crash in the recently added player codecProbe. 

operator():<MSE-media-player-5> Setting codec for stream (null) to avc1.64002A

Reproduces flakily on release builds (wasn't able to reproduce this on debug) when loading  https://interbrand.com/

For now I'll add a workaround/warning. This codec probe is not critically important, but there's a bug to dive in here, caps events should not reach a pad before stream-start.

[Philippe Normand]

Pull request: https://github.com/WebKit/WebKit/pull/13548

[EWS]

Committed 263791@main (c49bd915d945): <https://commits.webkit.org/263791@main>

Reviewed commits have been landed. Closing PR #13548 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/109034676>

[Philippe Normand]

This needs a proper patch...

[Michael Catanzaro]

(This was on the backport list for 2.40, but it depends on 263585@main which has many conflicts, so I decided not to cherry-pick it.)

[Philippe Normand]

(In reply to Philippe Normand from comment #4)
> This needs a proper patch...

This works now, I can't trigger the warning anymore...

[Carlos Bentzen]

(In reply to Philippe Normand from comment #6)
> (In reply to Philippe Normand from comment #4)
> > This needs a proper patch...
> 
> This works now, I can't trigger the warning anymore...

I can trigger this 100% of the time with media/media-source/media-source-abort-resets-parser.html in release mode (the test times out due to a deadlock as well, fwiw).

I'm working on fixing to that test, and with my current WIP solution, this warning also goes away. But the fix isn't quite ready to be merged yet. (bug 272975)