Bug 256428 - [GStreamer][MSE] Decoder sometimes receives caps event before stream-start
Summary: [GStreamer][MSE] Decoder sometimes receives caps event before stream-start
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-07 03:13 PDT by Philippe Normand
Modified: 2024-04-19 06:22 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2023-05-07 03:13:52 PDT
And that triggers a crash in the recently added player codecProbe. 

operator():<MSE-media-player-5> Setting codec for stream (null) to avc1.64002A

Reproduces flakily on release builds (wasn't able to reproduce this on debug) when loading  https://interbrand.com/

For now I'll add a workaround/warning. This codec probe is not critically important, but there's a bug to dive in here, caps events should not reach a pad before stream-start.
Comment 1 Philippe Normand 2023-05-07 03:19:01 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13548
Comment 2 EWS 2023-05-08 04:30:19 PDT
Committed 263791@main (c49bd915d945): <https://commits.webkit.org/263791@main>

Reviewed commits have been landed. Closing PR #13548 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-05-08 04:31:21 PDT
<rdar://problem/109034676>
Comment 4 Philippe Normand 2023-05-08 04:40:01 PDT
This needs a proper patch...
Comment 5 Michael Catanzaro 2023-05-25 14:34:22 PDT
(This was on the backport list for 2.40, but it depends on 263585@main which has many conflicts, so I decided not to cherry-pick it.)
Comment 6 Philippe Normand 2024-01-20 04:40:18 PST
(In reply to Philippe Normand from comment #4)
> This needs a proper patch...

This works now, I can't trigger the warning anymore...
Comment 7 Carlos Bentzen 2024-04-19 06:22:42 PDT
(In reply to Philippe Normand from comment #6)
> (In reply to Philippe Normand from comment #4)
> > This needs a proper patch...
> 
> This works now, I can't trigger the warning anymore...

I can trigger this 100% of the time with media/media-source/media-source-abort-resets-parser.html in release mode (the test times out due to a deadlock as well, fwiw).

I'm working on fixing to that test, and with my current WIP solution, this warning also goes away. But the fix isn't quite ready to be merged yet. (bug 272975)