Bug 256408 - [GPU Process] Cache all RenderingResources as one type
Summary: [GPU Process] Cache all RenderingResources as one type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 232845
  Show dependency tree / graph
 
Reported: 2023-05-05 19:39 PDT by Said Abou-Hallawa
Modified: 2023-05-08 14:19 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-05-05 19:39:17 PDT 
This makes adding a new RenderingResource less pervasive. RenderingResources are mainly cached to control their lifetime between WebProcess and GPUProcess. Their concrete types are rarely used especially in WebProcess. So replace the pointers to NativeImage, DecomposedGlyphs and Gradient to just a pointer to RenderingResource. Add to these classes traits so RenderingResource can be casted to any of them.
Comment 1 Radar WebKit Bug Importer 2023-05-05 19:42:32 PDT 
<rdar://problem/108977457>
Comment 2 Said Abou-Hallawa 2023-05-05 19:44:42 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13530
Comment 3 EWS 2023-05-08 14:19:39 PDT 
Committed 263824@main (d67761f1060a): <https://commits.webkit.org/263824@main>

Reviewed commits have been landed. Closing PR #13530 and removing active labels.