Bug 256371 - REGRESSION(STP169): wpt /css/css-overflow/webkit-line-clamp-040.html
Summary: REGRESSION(STP169): wpt /css/css-overflow/webkit-line-clamp-040.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-05 08:24 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-05-13 06:08 PDT (History)
13 users (show)

See Also:

Attachments
Patch (25.00 KB, patch)
2023-05-11 12:18 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (26.95 KB, patch)
2023-05-11 17:55 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (31.56 KB, patch)
2023-05-11 19:12 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (30.29 KB, patch)
2023-05-12 06:34 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (31.85 KB, patch)
2023-05-12 07:13 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (30.51 KB, patch)
2023-05-12 13:33 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (28.96 KB, patch)
2023-05-12 18:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2023-05-05 08:24:50 PDT 
<rdar://problem/108949870>
Comment 2 zalan 2023-05-05 08:51:42 PDT 
This change is intentional and I'd argue it's a progression (a slight divergence from what prefixed line-clamp used to produce, but surely a visual progression)
Comment 3 Sam Sneddon [:gsnedders] 2023-05-05 09:25:25 PDT 
It does take us out of alignment with every other browser, and given -webkit-line-clamp is now spec'd in a CSS WG spec we should probably file an issue there if we want to change behaviour?
Comment 4 zalan 2023-05-05 10:29:13 PDT 
(In reply to Sam Sneddon [:gsnedders] from comment #3)
> It does take us out of alignment with every other browser, and given
> -webkit-line-clamp is now spec'd in a CSS WG spec we should probably file an
> issue there if we want to change behaviour?
oh didn't know it got spec'd. that's a :|.
Comment 5 zalan 2023-05-11 12:18:10 PDT 
Created attachment 466321 [details]
Patch
Comment 6 EWS Watchlist 2023-05-11 12:21:26 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 7 zalan 2023-05-11 17:55:40 PDT 
Created attachment 466327 [details]
Patch
Comment 8 zalan 2023-05-11 19:12:23 PDT 
Created attachment 466330 [details]
Patch
Comment 9 zalan 2023-05-12 06:34:19 PDT 
Created attachment 466332 [details]
Patch
Comment 10 zalan 2023-05-12 07:13:26 PDT 
Created attachment 466333 [details]
Patch
Comment 11 zalan 2023-05-12 13:33:04 PDT 
Created attachment 466336 [details]
Patch
Comment 12 zalan 2023-05-12 18:31:43 PDT 
Created attachment 466341 [details]
[fast-cq]Patch
Comment 13 EWS 2023-05-13 06:08:01 PDT 
Committed 264048@main (8c497617ec2a): <https://commits.webkit.org/264048@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466341 [details].