256323 – [image-set] `type()` function should only take one string

RESOLVED FIXED 256323

[image-set] `type()` function should only take one string

https://bugs.webkit.org/show_bug.cgi?id=256323

Summary [image-set] `type()` function should only take one string

Tim Nguyen (:ntim)

Reported 2023-05-04 11:03:52 PDT

...

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-05-04 13:14:11 PDT

<rdar://problem/108909363>

Tim Nguyen (:ntim)

Comment 2 2023-05-04 13:15:13 PDT

To be clear, `type("image/png" "image/png")` should be rejected, this is tested by https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat

Ryan Reno

Comment 3 2023-05-04 21:21:05 PDT

I'm just consuming the whole block when consuming the type function. I'll look for a way to either specify how many arguments to consume or maybe just peek again and make sure it's a close paren token.

Ryan Reno

Comment 4 2023-05-21 14:50:27 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14161

EWS

Comment 5 2023-05-21 19:13:46 PDT

Committed 264310@main (f52fdf6f4c9f): <https://commits.webkit.org/264310@main> Reviewed commits have been landed. Closing PR #14161 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.