WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
256269
Make IsWeakCallback the default
https://bugs.webkit.org/show_bug.cgi?id=256269
Summary
Make IsWeakCallback the default
Ryan Reno
Reported
2023-05-03 13:57:13 PDT
Currently callbacks in the bindings generate Strong<> references which act as GC roots. It's probably a better default to create Weak<> references in the default case and provide a IsStrongCallback extended IDL attribute for cases where Strong<> is necessary.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-05-03 13:57:39 PDT
<
rdar://problem/108859209
>
Ryan Reno
Comment 2
2023-05-11 16:37:28 PDT
After my experience with MediaSession this is pretty ambitious. There can be non-trivial logic involved in keeping callbacks alive.
Ryan Reno
Comment 3
2024-07-02 15:51:37 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/30415
EWS
Comment 4
2024-07-02 22:36:56 PDT
Committed
280611@main
(39ee5e3e49f1): <
https://commits.webkit.org/280611@main
> Reviewed commits have been landed. Closing PR #30415 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug