WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
25625
Implement Image/Option constructors in V8
https://bugs.webkit.org/show_bug.cgi?id=25625
Summary
Implement Image/Option constructors in V8
Dimitri Glazkov (Google)
Reported
2009-05-07 12:12:52 PDT
This helps us unfork DOMWindow.idl
Attachments
Implement Image/Option constructors in V8, v1
(10.80 KB, patch)
2009-05-07 12:17 PDT
,
Dimitri Glazkov (Google)
no flags
Details
Formatted Diff
Diff
Implement Image/Option constructors in V8, v2
(10.79 KB, patch)
2009-05-07 12:28 PDT
,
Dimitri Glazkov (Google)
fishd
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2009-05-07 12:17:33 PDT
Created
attachment 30108
[details]
Implement Image/Option constructors in V8, v1 WebCore/ChangeLog | 12 +++ WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp | 60 ------------- .../v8/custom/V8HTMLImageElementConstructor.cpp | 73 ++++++++++++++++ .../v8/custom/V8HTMLOptionElementConstructor.cpp | 90 ++++++++++++++++++++ 4 files changed, 175 insertions(+), 60 deletions(-)
Dimitri Glazkov (Google)
Comment 2
2009-05-07 12:28:15 PDT
Created
attachment 30109
[details]
Implement Image/Option constructors in V8, v2 WebCore/ChangeLog | 12 +++ WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp | 60 ------------- .../v8/custom/V8HTMLImageElementConstructor.cpp | 73 ++++++++++++++++ .../v8/custom/V8HTMLOptionElementConstructor.cpp | 90 ++++++++++++++++++++ 4 files changed, 175 insertions(+), 60 deletions(-)
Dimitri Glazkov (Google)
Comment 3
2009-05-07 12:28:55 PDT
Comment on
attachment 30108
[details]
Implement Image/Option constructors in V8, v1 Whoops. Fixing a few boogers.
Dimitri Glazkov (Google)
Comment 4
2009-05-10 11:41:45 PDT
Landed as
http://trac.webkit.org/changeset/43360
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug