Bug 25625 - Implement Image/Option constructors in V8
Summary: Implement Image/Option constructors in V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-07 12:12 PDT by Dimitri Glazkov (Google)
Modified: 2009-05-10 11:41 PDT (History)
0 users

See Also:


Attachments
Implement Image/Option constructors in V8, v1 (10.80 KB, patch)
2009-05-07 12:17 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Implement Image/Option constructors in V8, v2 (10.79 KB, patch)
2009-05-07 12:28 PDT, Dimitri Glazkov (Google)
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-05-07 12:12:52 PDT
This helps us unfork DOMWindow.idl
Comment 1 Dimitri Glazkov (Google) 2009-05-07 12:17:33 PDT
Created attachment 30108 [details]
Implement Image/Option constructors in V8, v1

 WebCore/ChangeLog                                  |   12 +++
 WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp   |   60 -------------
 .../v8/custom/V8HTMLImageElementConstructor.cpp    |   73 ++++++++++++++++
 .../v8/custom/V8HTMLOptionElementConstructor.cpp   |   90 ++++++++++++++++++++
 4 files changed, 175 insertions(+), 60 deletions(-)
Comment 2 Dimitri Glazkov (Google) 2009-05-07 12:28:15 PDT
Created attachment 30109 [details]
Implement Image/Option constructors in V8, v2

 WebCore/ChangeLog                                  |   12 +++
 WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp   |   60 -------------
 .../v8/custom/V8HTMLImageElementConstructor.cpp    |   73 ++++++++++++++++
 .../v8/custom/V8HTMLOptionElementConstructor.cpp   |   90 ++++++++++++++++++++
 4 files changed, 175 insertions(+), 60 deletions(-)
Comment 3 Dimitri Glazkov (Google) 2009-05-07 12:28:55 PDT
Comment on attachment 30108 [details]
Implement Image/Option constructors in V8, v1

Whoops. Fixing a few boogers.
Comment 4 Dimitri Glazkov (Google) 2009-05-10 11:41:45 PDT
Landed as http://trac.webkit.org/changeset/43360.