With https://bugs.webkit.org/show_bug.cgi?id=256179, there can sometimes be a 1px difference in the results for this test. Worse, the difference is only between EWS and my local machine (both are consistent, but different).
<rdar://problem/108800436>
Created attachment 466176 [details] Patch
Created attachment 466177 [details] Patch
Comment on attachment 466177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466177&action=review > LayoutTests/accessibility/mac/bounds-for-range.html:27 > + output += expectAny("textChild.boundsForRange(6,10)", ["{{-1.000000, -1.000000}, {60.000000, 18.000000}}", "{{-1.000000, -1.000000}, {61.000000, 18.000000}}"]); should we make something for robust, like expectWithVariance(textChild.boundsFor, "1, 1, 50, 18", "3.0") and then you have the parse the frame but that's not too hard
Created attachment 466182 [details] Patch
(In reply to chris fleizach from comment #4) > Comment on attachment 466177 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466177&action=review > > > LayoutTests/accessibility/mac/bounds-for-range.html:27 > > + output += expectAny("textChild.boundsForRange(6,10)", ["{{-1.000000, -1.000000}, {60.000000, 18.000000}}", "{{-1.000000, -1.000000}, {61.000000, 18.000000}}"]); > > should we make something for robust, like > > expectWithVariance(textChild.boundsFor, "1, 1, 50, 18", "3.0") > > and then you have the parse the frame but that's not too hard Fixed in the latest patch.
nice!
Created attachment 466183 [details] Patch
Committed 263617@main (de2c64350b4c): <https://commits.webkit.org/263617@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466183 [details].